fix(fslib): correct the FileHandle implementation
#3889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@merceyz I got an error like const handle = await fs.promises.open(filepath, 'r');
const { size } = await handle.stat();And that number seems to be the file handle's fd number. I assume it will be fixed by this PR as well? |
1 task
merceyz
force-pushed
the
merceyz/fix/filehandle
branch
2 times, most recently
from
cc04d53
to
0987811
Compare
@Josh-Cena Yes |
merceyz
changed the title
FileHandle functions to their fd counterpartFileHandle implementation
merceyz
force-pushed
the
merceyz/fix/filehandle
branch
from
d606f76
to
40186c3
Compare
merceyz
force-pushed
the
merceyz/fix/filehandle
branch
from
40186c3
to
0dfe5ff
Compare
merceyz
force-pushed
the
merceyz/fix/filehandle
branch
2 times, most recently
from
54a9b32
to
14378ba
Compare
This comment was marked as spam.
This comment was marked as spam.
merceyz
force-pushed
the
merceyz/fix/filehandle
branch
from
14378ba
to
00fa18c
Compare
merceyz
force-pushed
the
merceyz/fix/filehandle
branch
2 times, most recently
from
496794c
to
b5866f5
Compare
merceyz
force-pushed
the
merceyz/fix/filehandle
branch
from
b5866f5
to
52c133f
Compare
merceyz
force-pushed
the
merceyz/fix/filehandle
branch
from
52c133f
to
8e2c498
Compare
merceyz
added a commit
that referenced
this pull request
Jul 20, 2022
* fix(fslib): map `FileHandle` functions to their fd counterpart * fix: `FileHandle.write` * refactor: avoid needing tslib update * test: `FileHandle.read` * test: `FileHandle.readFile` * test: `FileHandle.appendFile` * fix: `FileHandle.writeFile` * refactor: use symbols for internals * fix: ref counter * fix: throw when when using a closed FileHandle * fix: handle passing `FileHandle` to `fs.promises` functions * fix: `FileHandle.writev` * fix: `FileHandle.truncate` * fix: `FileHandle.chmod` * chore: versions * chore: changelog * chore: install
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The patched filesystem doesn't implement
FileHandlecorrectly.writevmethod in patched FileHandle implementation #2083filehandle.truncate(len)broken usingyarn node#4372Depends on
fchmodsupport #4466ftruncatesupport #4477How did you fix it?
Implemented most of the
FileHandlemethods.Checklist